Upgrade Webpack from 2.7.0 to 4.1.0

vega / voyager

Visualization Tool for Data Exploration

http://vega.github.io/voyager

Other

1.45k stars 179 forks source link

Upgrade Webpack from 2.7.0 to 4.1.0 #866

Closed siyaoL1 closed 2 years ago

siyaoL1 commented 3 years ago

List of upgraded dependencies:

@types/react
@types/webpack
css-loader
extract-text-webpack-plugin
file-loader
html-webpack-plugin
node-sass
postcss-loader
react-dev-utils
react-hot-loader
sass-loader
source-map-loader
ts-loader
typescript
url-loader
webpack
webpack-cli
webpack-dev-server
webpack-manifest-plugin

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 243c58842948b06550c491c5495f6b6531e4dc08 into 896319b12da635c51ce410f512c84debd779296a - view on LGTM.com

new alerts:

1 for Overwritten property

domoritz commented 3 years ago

Please resolve the conflicts.

domoritz commented 3 years ago

Did you see https://github.com/vega/voyager/pull/866#issuecomment-880603988?

siyaoL1 commented 3 years ago

Yes I'm currently working on it

domoritz commented 3 years ago

Marking as draft. Please let me know when it's ready.

domoritz commented 3 years ago

@kanitw do you have any concerns about the changes here?

domoritz commented 2 years ago

@siyaoL1 Could you look at my unresolved comments?

siyaoL1 commented 2 years ago

Yes, I will definitely do that

domoritz commented 2 years ago

Please resolve the issue and conflicts and then mark the pull request as ready.