Upgraded to Typescript@3.6, Vega@5.2, Vega-Lite@3.4, Webpack@4.1

vega / voyager

Visualization Tool for Data Exploration

http://vega.github.io/voyager

Other

1.45k stars 179 forks source link

Upgraded to Typescript@3.6, Vega@5.2, Vega-Lite@3.4, Webpack@4.1 #886

Open siyaoL1 opened 2 years ago

siyaoL1 commented 2 years ago

List of upgraded dependencies:

ajv
vega
vega-lite
compassql
vega-datasets
vega-expression
vega-tooltip
vega-typings
vega-util
vega-functions
css-loader
extract-text-webpack-plugin
file-loader
html-webpack-plugin
postcss-loader
react-dnd
react-dev-utils
react-hot-loader
sass-loader
source-map-loader
terser-webpack-plugin
ts-jest
ts-loader
typescript
url-loader
webpack
webpack-cli
webpack-dev-server
webpack-manifest-plugin
@types/webpack
@types/node
@types/react

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts when merging 320bc0410a184bec2f9717bb4a54a88446df7f83 into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Unreachable statement

siyaoL1 commented 2 years ago

I will work on addressing the comments

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts when merging 8822adffc3ce0631beab3e328e7362aae31f50fe into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Unreachable statement

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging d86b3e79a62ff36e1fa22a0a83c42b2a18c8b7e5 into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 40bec63c67c4de5d82ebc7b07a4b1a7aad009fae into 882809fb2aafdec1d967505a7c41efc9b78b021f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

domoritz commented 2 years ago

Please fix the tests

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 6d04f8455877a2702d2ba530f7c9ee0204c43493 into 2bd9d86efc7ed312d54d4ae5c390cbf05d75cbde - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

domoritz commented 2 years ago

Let me know when tests pass.

siyaoL1 commented 2 years ago

Thanks! I just addressed the comments and deleted the unavailable datasets, and I have tested that the app works as expected. Would you like me to add more datasets from vega-datasets?

domoritz commented 2 years ago

@siyaoL1 is working on support CSV and then we can merge this.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 0bd2706fd2f568956ccd1932b597d2dd9042e1d9 into 2bd9d86efc7ed312d54d4ae5c390cbf05d75cbde - view on LGTM.com

new alerts:

1 for Incomplete multi-character sanitization