DataType Pre-Values get re-added, breaking all loaded content

[Myster]

Given the following example: Every time the datatypes sync the pre-values get re-added to the DB, causing the IDs to change, and existing content to become corrupt. The same issue occurs with DropDownLists and other datatypes where the content saves the prevalue primary key.

namespace Example.UmbracoWebsite.DataTypes
{
    [DataType(Name = "Approved Color", UniqueId = "0225af17-b302-49cb-9176-b9f35cab9c17", RenderControlGuid = "f8d60f68-ec59-4974-b43b-c46eb5677985", DatabaseDataType = DBTypes.Nvarchar)]
    public partial class ApprovedColor : DataTypeBase
    {
        public override DataTypePrevalue[] Prevalues
        {
            get
            {
                return new DataTypePrevalue[]
                {
                    new DataTypePrevalue("", "eeeeee"),
                    new DataTypePrevalue("", "7fffd4"),
                    new DataTypePrevalue("", "ff00ff")
                };
            }
        }
    }
}

[JimBobSquarePants]

Any update on this?

[spopovic]

We'll try to fix it this week.

[spopovic]

@JimBobSquarePants, should be fixed now.

[JimBobSquarePants]

Awesome... Was gonna have a go myself but not had the chance. :+1:

[spopovic]

@JimBobSquarePants, did you have a chance to check it? Can we close the issue now?

[JimBobSquarePants]

I've not had a chance to test yet. Code looks sensible though, I'll update as soon as I can. I say close for now as I'm sure you conducted tests. We can always reopen.

[Myster]

I haven't tried this, but I did look at the commit 27487d3, I've put a note there