vegaitglobal / uSiteBuilder

Vega IT’s uSitebuilder is an open source (LPGL) framework created for .NET developers to accelerate and streamline their Umbraco based development projects. Our objective is to enable back-end developers to adhere to the .NET standards with minimal external interaction, and to facilitate the automation of their deployments.
GNU Lesser General Public License v2.1
29 stars 21 forks source link

Document type alias - spaces should not be allowed #7

Closed dougludlow closed 10 years ago

dougludlow commented 10 years ago

We should either throw an exception if there are spaces in the document type alias or automatically clean the given alias so that it is valid. Currently, if an invalid alias is set, uSiteBuilder does nothing, there are weird conflicts that occur as a result. How should we handle this?

spopovic commented 10 years ago

Throwing an exception sounds like a good solution.

spopovic commented 10 years ago

Any other suggestions?

@dougludlow, did you want to make the change and make a pull request or would you like us to take it over and do the work on our end?

dougludlow commented 10 years ago

@spopovic I made the change in #8. I believe you already merged the pull request.