search

vegapnk / RJW-Genes

Rimworld Biotech Genes related to RJW
MIT License
32 stars 33 forks source link

VGE Children spawn unrelated to settings #116

Closed vegapnk closed 2 weeks ago

vegapnk commented 2 months ago

I got different reports on discord which are contradicting: 

A: I keep getting human/animal hybrids even though i've set: Enable VGE hybridization to off
Or it seems to always happen with a thrumbo

B: Odd, because I haven't had luck with that, despite multiple attempts.

Me: [Explaining some mechanics as intended]

A: Yeah, it's what I was expecting originally to happen with the thrumbo. Not getting the thrumbman hybrid from VGE with that option turned off

C: I think I have the opposite issue, I've never gotten any VGE hybrids from it, maybe I'm just unlucky

Not sure what is up with it, but maybe the Settings are switched.

This seems to be correctly exiting the prefix if settings are turned off

vegapnk commented 1 month ago

I have gotten some more information and it seemed to still occurr into 2.2.0.

Reported Modlist: 

Prepatcher
Harmony
Rimworld 
Rimworld - Royalty
Rimworld - Ideology
Rimworld - Biotech
Rimworld - Anomaly
HugsLib
Character Editor
RimJobWorld
Vanilla Expanded Framework
RJW Genes
Vanilla Genetics Expanded

Except for the Prepatcher all seems good and fine. There also was a bit of debate if this is related to Animal Pregnancy and it's interactions with Menstruation. Menstruation has an option to choose which animal-pregnancy to use, if they use theirs it turns of default preg and if you don't it goes into RJW and then mine.

vegapnk commented 1 month ago

This Could be the culprit with the missing null-check!!

vegapnk commented 1 month ago

People are getting super professional;

I got this modlist and Save-File To share.zip

ModList is pretty long but nothing crazy in it.

vegapnk commented 3 weeks ago

I am very certain that it comes from this xml file which also specifies what parents make what offspring. Things are running even if I did comment out all C# Patches, this means that this originates from RJW Base IFF my XML looks like this.

vegapnk commented 3 weeks ago

I am working on changing the PawnKindDef, but this is not enough for the RJW Pregnancy. This file sets the Pawnkind, but reads a lot of references from the actual parent and then sends a full PawnGenerationRequest.

I checked what happened when I just alter this one field and I got a lot of red errors, the birth was fucked and what not.

This means I have to do it a bit more complicated - the PawnKind must be set before the GenerationRequest is given.