vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
21 stars 14 forks source link

Feat/375: Risk notice dialog #1096

Closed notbot00 closed 1 year ago

notbot00 commented 1 year ago

Related issues 🔗

Closes #375

Description ℹī¸

Display a risk notice on mainnet. Also has some dialog fixes, as the transform styles completely mess up the mobile display for the dialogs

Demo đŸ“ē

Screenshot 2022-08-19 at 17 23 57
netlify[bot] commented 1 year ago

Deploy Preview for vega-trading-app canceled.

Name Link
Latest commit 02ab3224fa9138368a44e1dcc5902b68f71b989c
Latest deploy log https://app.netlify.com/sites/vega-trading-app/deploys/6311ff6bf1e34200089c6d90
netlify[bot] commented 1 year ago

Deploy Preview for vega-explorer canceled.

Name Link
Latest commit 02ab3224fa9138368a44e1dcc5902b68f71b989c
Latest deploy log https://app.netlify.com/sites/vega-explorer/deploys/6311ff6bc1b81e0008100a12
netlify[bot] commented 1 year ago

Deploy Preview for vega-ui-toolkit processing.

Name Link
Latest commit 02ab3224fa9138368a44e1dcc5902b68f71b989c
Latest deploy log https://app.netlify.com/sites/vega-ui-toolkit/deploys/6311ff6b77dfda00081b5d68
netlify[bot] commented 1 year ago

Deploy Preview for token-dapp-dev canceled.

Name Link
Latest commit 02ab3224fa9138368a44e1dcc5902b68f71b989c
Latest deploy log https://app.netlify.com/sites/token-dapp-dev/deploys/6311ff6bc1b81e0008100a1a
netlify[bot] commented 1 year ago

Deploy Preview for market-depth processing.

Name Link
Latest commit 02ab3224fa9138368a44e1dcc5902b68f71b989c
Latest deploy log https://app.netlify.com/sites/market-depth/deploys/6311ff6bebbf6c0008861d83
netlify[bot] commented 1 year ago

Deploy Preview for console-lite canceled.

Name Link
Latest commit 02ab3224fa9138368a44e1dcc5902b68f71b989c
Latest deploy log https://app.netlify.com/sites/console-lite/deploys/6311ff6bebbf6c0008861d81
cypress[bot] commented 1 year ago



Test summary

47 0 9 0


Run details

Project frontend-monorepo
Status Passed
Commit 02ab3224fa
Started Sep 2, 2022 2:07 PM
Ended Sep 2, 2022 2:18 PM
Duration 11:27 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡ī¸


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

notbot00 commented 1 year ago

thanks, fixed

PeteWilliams commented 1 year ago

I notice that this has the close icon in the corner. This could potentially be a legal issue if people can proceed without acknowledging the warning. I'd suggest removing the icon or checking with Dave Mac if we are OK to keep it.

notbot00 commented 1 year ago

(blocking): the font size on this one is quite big and different from what we are using around console. I have seen this also in tooltips and environment popover/dropdowns. can we make sure we are using text-ui or text-ui-small across console?

@MadalinaRaicu i've added text-ui classes, nothing happened. not sure tbh how our typography works, i don't think it does how i'd expect it to 🤔

notbot00 commented 1 year ago

I notice that this has the close icon in the corner. This could potentially be a legal issue if people can proceed without acknowledging the warning. I'd suggest removing the icon or checking with Dave Mac if we are OK to keep it.

@PeteWilliams makes sense, removed the closing option

MadalinaRaicu commented 1 year ago

(blocking): the font size on this one is quite big and different from what we are using around console. I have seen this also in tooltips and environment popover/dropdowns. can we make sure we are using text-ui or text-ui-small across console?

@MadalinaRaicu i've added text-ui classes, nothing happened. not sure tbh how our typography works, i don't think it does how i'd expect it to 🤔

maybe with the new design changes it will appear differently. not sure my comment applies anymore.