vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
21 stars 14 forks source link

Feat/1491 insert accounts and positions #1515

Closed macqbat closed 1 year ago

macqbat commented 1 year ago

Related issues 🔗

Closes #1491 Closes #1391

Description ℹī¸

Handle adding new rows from subscriptions on account and positions views

Technical 👨‍🔧

Extend dependencies in data providers and merge data from a few sources in one set

netlify[bot] commented 1 year ago

Deploy Preview for vega-ui-toolkit processing.

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/vega-ui-toolkit/deploys/633bec1e2ef616000996f1f4
netlify[bot] commented 1 year ago

Deploy Preview for token-dapp-dev canceled.

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/token-dapp-dev/deploys/633bec1e72970100099c8fc8
netlify[bot] commented 1 year ago

Deploy Preview for vega-explorer-testnet ready!

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/vega-explorer-testnet/deploys/633bec1e34b7020008cd2fc0
Deploy Preview https://deploy-preview-1515--vega-explorer-testnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for vega-trading-app ready!

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/vega-trading-app/deploys/633bec1e34b7020008cd2fbb
Deploy Preview https://deploy-preview-1515--vega-trading-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for console-lite ready!

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/console-lite/deploys/633bec1e2ef616000996f1f9
Deploy Preview https://deploy-preview-1515--console-lite.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for market-depth processing.

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/market-depth/deploys/633bec1e15869a000975516d
netlify[bot] commented 1 year ago

Deploy Preview for liquidity-provision-dashboard canceled.

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/liquidity-provision-dashboard/deploys/633bec1fa79dfc0008697697
cypress[bot] commented 1 year ago



Test summary

28 1 1 3


Run details

Project frontend-monorepo
Status Failed
Commit e2dad1ccf0
Started Sep 29, 2022 9:47 AM
Ended Sep 29, 2022 9:48 AM
Duration 01:41 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡ī¸


Failures

src/integration/portfolio-page.test.ts Failed
1 Portfolio page > Positions view > data should be properly rendered

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] commented 1 year ago



Test summary

42 0 7 0


Run details

Project frontend-monorepo
Status Passed
Commit 6ecfe9682a ℹī¸
Started Oct 4, 2022 8:30 AM
Ended Oct 4, 2022 8:33 AM
Duration 03:11 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡ī¸


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

MadalinaRaicu commented 1 year ago

@macqbat pulled your branch and something is wrong in collateral tab aggregation now, and this problem is not in develop. I was on stagnet3, had no collateral initially, but then topped up with 50,000 fDAI. as I was switching between tabs deposited became 100,000 fDAI. checked out back to develop and this issue was not there anymore. I am not sure why this happens.

image

as I was trying to debug I saw update method was called with deltas twice

netlify[bot] commented 1 year ago

Deploy Preview for vega-tools canceled.

Name Link
Latest commit 409c6c4b3072d2b421a256fbee950e3db8693e4c
Latest deploy log https://app.netlify.com/sites/vega-tools/deploys/633bec1e3181c8000999c277