vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
22 stars 15 forks source link

chore: market header live update #1672

Closed macqbat closed 1 year ago

macqbat commented 1 year ago

Related issues 🔗

Closes #1595

Description ℹī¸

Make market header live updated

Demo đŸ“ē

Screenshot 2022-10-06 at 16 16 31

Technical 👨‍🔧

Use data provider with subscription for candles and marketData instead cached useQuery

netlify[bot] commented 1 year ago

Deploy Preview for vega-explorer-testnet ready!

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/vega-explorer-testnet/deploys/634551a50b609400097d8d27
Deploy Preview https://deploy-preview-1672--vega-explorer-testnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for liquidity-provision-dashboard canceled.

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/liquidity-provision-dashboard/deploys/634551a5fd4c310009149a56
netlify[bot] commented 1 year ago

Deploy Preview for vega-ui-toolkit processing.

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/vega-ui-toolkit/deploys/634551a5fd4c310009149a4c
netlify[bot] commented 1 year ago

Deploy Preview for vega-tools canceled.

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/vega-tools/deploys/634551a54d6a3a000a8c6a02
netlify[bot] commented 1 year ago

Deploy Preview for token-dapp-dev canceled.

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/token-dapp-dev/deploys/634551a5fd4c310009149a51
netlify[bot] commented 1 year ago

Deploy Preview for market-depth processing.

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/market-depth/deploys/634551a50b609400097d8d2d
netlify[bot] commented 1 year ago

Deploy Preview for console-lite canceled.

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/console-lite/deploys/634551a5abe604000be66381
netlify[bot] commented 1 year ago

Deploy Preview for vega-trading-app ready!

Name Link
Latest commit 5a7e90c3096222925fc9612b58d0d2d801cb6e5d
Latest deploy log https://app.netlify.com/sites/vega-trading-app/deploys/634551a55146ab00084aef73
Deploy Preview https://deploy-preview-1672--vega-trading-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cypress[bot] commented 1 year ago



Test summary

18 0 0 0


Run details

Project frontend-monorepo
Status Passed
Commit 3c55ef55c8 ℹī¸
Started Oct 11, 2022 11:28 AM
Ended Oct 11, 2022 11:29 AM
Duration 00:56 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡ī¸


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

MadalinaRaicu commented 1 year ago

market.depth.lastTrade.price should not be included in marketProvider. lastTrade is real time data and this provider does not have subscriptions. Value should be taken from market depth provider (it needs to be modified to get this value)

@bglownia this reminds me that last trade price is shown in deal ticket. I think we are not using a data provider over there just simple query. we may need a ticket