vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
22 stars 15 forks source link

Fix/1622 proposal vote deadline fixes #1730

Closed sam-keen closed 1 year ago

sam-keen commented 1 year ago

Related issues 🔗

Closes #1622

Description ℹī¸

Some intermittent proposal subscription errors were being seen when the 'use minimum' and 'use maximum' buttons were clicked. Investigation into this uncovered that the proposal form fields weren't updating the form state when the buttons were used.

Secondarily, we had been adding 2 mins of extra time to the proposal vote deadline when the minimum was set, but had hardcoded that it happen when the vote deadline was set to 1 hour. This PR changes it to be inline with the nearest rounded hour to the vote deadline from the network parameter for the proposal form type. This means proposal forms with min deadlines longer than 1 hour now also get the extra 2 mins added (without which proposal could error if the user spent some time confirming in their wallet).

netlify[bot] commented 1 year ago

Deploy Preview for vega-ui-toolkit processing.

Name Link
Latest commit 37043167f8fac24ca6b3b243ae1041ec510d4299
Latest deploy log https://app.netlify.com/sites/vega-ui-toolkit/deploys/635154def68f150009628141
netlify[bot] commented 1 year ago

Deploy Preview for vega-trading-app canceled.

Name Link
Latest commit 37043167f8fac24ca6b3b243ae1041ec510d4299
Latest deploy log https://app.netlify.com/sites/vega-trading-app/deploys/635154deecc2170009193f7d
netlify[bot] commented 1 year ago

Deploy Preview for console-lite ready!

Name Link
Latest commit 37043167f8fac24ca6b3b243ae1041ec510d4299
Latest deploy log https://app.netlify.com/sites/console-lite/deploys/635154dec28c8b0009a20b8a
Deploy Preview https://deploy-preview-1730--console-lite.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for token-dapp-dev canceled.

Name Link
Latest commit 6952b7969a610a7fc2f2dd09b3f86aeb372c3c88
Latest deploy log https://app.netlify.com/sites/token-dapp-dev/deploys/6349769e9f7ef200096a6d47
netlify[bot] commented 1 year ago

Deploy Preview for market-depth processing.

Name Link
Latest commit 37043167f8fac24ca6b3b243ae1041ec510d4299
Latest deploy log https://app.netlify.com/sites/market-depth/deploys/635154dea727410009e725ae
netlify[bot] commented 1 year ago

Deploy Preview for vega-explorer-testnet ready!

Name Link
Latest commit 37043167f8fac24ca6b3b243ae1041ec510d4299
Latest deploy log https://app.netlify.com/sites/vega-explorer-testnet/deploys/635154dee19e9d00086a49de
Deploy Preview https://deploy-preview-1730--vega-explorer-testnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for liquidity-provision-dashboard canceled.

Name Link
Latest commit 37043167f8fac24ca6b3b243ae1041ec510d4299
Latest deploy log https://app.netlify.com/sites/liquidity-provision-dashboard/deploys/635154deafc9a60008874be8
netlify[bot] commented 1 year ago

Deploy Preview for vega-tools canceled.

Name Link
Latest commit 37043167f8fac24ca6b3b243ae1041ec510d4299
Latest deploy log https://app.netlify.com/sites/vega-tools/deploys/635154de57e7db000803a027
cypress[bot] commented 1 year ago



Test summary

70 0 5 0


Run details

Project frontend-monorepo
Status Passed
Commit 0b990e53e8 ℹī¸
Started Oct 20, 2022 2:06 PM
Ended Oct 20, 2022 2:09 PM
Duration 03:00 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡ī¸


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

netlify[bot] commented 1 year ago

Deploy Preview for stagnet1-trading failed.

Name Link
Latest commit b5d93c2c2d5421bb5f4cfa8161c68dd5e5903ba1
Latest deploy log https://app.netlify.com/sites/stagnet1-trading/deploys/634719b1c6b0d40009e33f3b
netlify[bot] commented 1 year ago

Deploy Preview for stagnet1-lp-dashboard canceled.

Name Link
Latest commit 6952b7969a610a7fc2f2dd09b3f86aeb372c3c88
Latest deploy log https://app.netlify.com/sites/stagnet1-lp-dashboard/deploys/6349769e204a2d0009c14903