vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
25 stars 18 forks source link

Improve date picker in ag-grid column filters #2948

Closed macqbat closed 3 weeks ago

macqbat commented 1 year ago

The Chore

Currently we date pickering in ag-grid is done by native picker of the browsers. Despite few advantages of such solution (easy handling of the mobile view, easy maintenance) it provides more potential problems:

It is to be considered, if better solution would be to use external library for date picker, like ie react-datepicker. Despite the overhead of the amount of code it offers quite good features: flexible api, possibility of get exactly what we need. We could get unified view of UI.

So instead current solution: Screenshot 2023-02-21 at 09 41 30

we could get IMHO better one:

image

Tasks

Additional details / background info

macqbat commented 1 year ago

The other weaknesses of native date pickers are: