vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
25 stars 18 forks source link

SPIKE: Network upgrade in progress now, or happened recently #3319

Closed pennyandrews closed 1 year ago

pennyandrews commented 1 year ago

We need to understand more about what we can get from the API and what we need to gather from other places

For example: if I come to console, there was an upgrade scheduled to have taken place recently, but nothing is happening... is the upgrade in progress still or is there another problem happening.

What if I'm connected to a node that hasn't come back up so blocks haven't progressed, but others have. Could be simple things "upgrade scheduled for x, visit block explorer to find out what's happening"

Define the scenarios and define what we can do to help people for each

Story

As a console user I want to know when a network upgrade is taking place So that I have visibility of what's happening with the network, am reassured that nothing bad is happening, and am provided with information to help me decide what action I need to take

Acceptance Criteria

Tasks

Sketch

Screenshot 2023-03-30 at 10 36 02

Additional details / background info

Details of what data is available from the API to facilitate this story can be found in this spike https://github.com/vegaprotocol/frontend-monorepo/issues/2992

JonRay15 commented 1 year ago

One the upgrade has concluded we also need a solution for what to show on console for the period it was out.

Currently we just show a gap.

image

JonRay15 commented 1 year ago

I also wonder what we do for auctions? Like if an auction takes 15 mins to conclude, what do we show for the candles during that 15 mins? In some ways this is no different to a network outage / upgrade ... it is a period where we arent tracking a price and dont really have any data - although I guess for an auction we could choose to show a indicative uncrossing price for each interval if that is useful.

JonRay15 commented 1 year ago

Consensus seems to be we should show a line for "forward fill" and take the last close price as the open, close, high and low. for all intervals until we have data again. Same thing we should do for any interval that doesnt have any volume.

Kucoin example

image

JonRay15 commented 1 year ago

Note that in te above, if the next trade was at a diff price you will still get a vertical jump like we see about 3/4 across on the above, but you should never have a horizontal gap.