vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
25 stars 18 forks source link

Update rewards view #4532

Closed JonRay15 closed 10 months ago

JonRay15 commented 1 year ago

Story

As a user I want to see details of various discounts / rewards I'm getting So that I feel like a valued customer and can tell what I should be doing to earn / maximise my rewards

Acceptance Criteria

Tasks

Sketch

Figma

We are going for v2.4 in the Figma

Image

Where there are various levels as indicated in the additional sketch in the Figma

Image

Also using v2.1 of the reward cards.

https://www.figma.com/file/ywcCZvXdvG28bg0AmCY9mF/Console-v3?type=design&node-id=3166-5839&mode=design&t=GXj0QjK0d268FwQ1-0

Additional details / background info

API details

{
  partiesConnection(id:"89fd87b86727fa4d9ab06b9f4e64b51c9b07055e8a0c8f0bc40f0a249e321525"){
    edges{
      node{
        id
        activityStreak{
          activeFor
          isActive
          inactiveFor
          rewardDistributionMultiplier
          rewardVestingMultiplier
          epoch
          tradedVolume
          openVolume
        }
      }
    }
  }
}

Note that we have had some issues with pagination on that rewards page on the governance page, which are documented on the ticket below, so we should make sure we handle this nicely on the new console version.

https://github.com/vegaprotocol/frontend-monorepo/issues/3471

JonRay15 commented 1 year ago

This is now covered by #4713 and #4714

We dont need this

JonRay15 commented 1 year ago

Given the above, the only likely thing to do here would be some sort of summary savings in the Portfolio page.

But that will require the ledger entries summary API in order to get this detail out, so until we get some movement there this is blocked.

mattrussell36 commented 1 year ago

If we cant show summary data. As a first step it might still be good to show your current discount tier status and perhaps volume required to hit the next tier (same for referrals), based on the API requirements here we should be good.

Some simple cards might be a good start. Or perhaps an indicator in the key dropdown if discounts are active

Image

JonRay15 commented 1 year ago

Note Matt's comment above is old and not relevant for this ticket now that it has been broken out to cover only the rewards stuff ... so if you're thinking it is confusing, thats why.

JonRay15 commented 1 year ago

We should make a start on this @mattrussell36

We can hide a bunch of things and focus on getting the important stuff for vesting out.

Image

mattrussell36 commented 11 months ago

This first part of this is done. But we still need to implement the activity streaks and the reward tiles

JonRay15 commented 11 months ago

We also need to have handling for when there is no activity streak and no reward hoarder streak active in mainnet ... which is currently the case.

JonRay15 commented 11 months ago

Agreed card option 1

Image