New markets page snags - Githubissues

JonRay15 commented 5 months ago

The Chore

Feedback for further improvements to the markets page

Sorting issue

[ ] 24h volume is sorting by the raw number (correction ... it is sorting by .... I dont know what ... it seems pretty random!) when ideally it would sort by the USDT equivalent given below
[ ] Same issue for open interest
[ ] 24h Change is sorting by lord knows what ... it seems to think zero (no change) is the lowest number possible and its sorting the other stuff seemingly at random - weirdly the "Top gainers" section is sorting just fine

DP issues

[ ] The 24h volume and open interest as expressed in contracts should be given to the marketDp of the market
[ ] The 24h volume and open interest as expressed in USD should be given to ZERO DP

Column width

I have lost the edge of the "open interest" column on a 13in monitor with 90% zoom on Chrome. If I go to 100% I lose it almost completely. Therefore in both cases I have a horizontal scroll bar.

[ ] Adjust default column widths so we fit all columns on a 13in monitor at 100% zoom

Column widths on Proposed & Closed

[ ] On these panes it looks like we need wider columns because theres just dead space on the far right?

Spacing / padding

[x] In my opinion the rows still need more top and bottom padding... it feels a bit dense for this "websitey" vibe we are going for.
[ ] I think the icons could be a little bigger too
[ ] I think the font of the "primary" info in the table (market code, price etc) could be bigger to distinguish it more from the "secondary" grey info

24h change section

It seems like the spark line graph doesnt fill the entire height of the row? The chart starts from maybe a third of the way up? But then it goes to the very top?

I'm conscious this is a share component with the market dropdown so anythign we do here will impact that too.

Its particularly jarring on things in auction where they get this weird grey bar.

Not sure exactly is the best course of action ... I can think of two:

Fill the full row top to bottom, but given we have the fill under the line that will mean a lot of filled in space. We would likely need to cut it off somewhere so maybe we have a margin top and bottom but lets have the same margin since at the moment it is only really occupying the top 2/3 of the row
If we think that is going to lead to too much filled space, could we do that but not have the gradient fill under the line? It seems to me that it is that gradient - and trying to work out where it stops - that is causing the issue here? If I look at other examples most dont have that gradient under the line so dont face this problem