vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
21 stars 14 forks source link

feat(trading): market trading mode icons #6370

Closed MadalinaRaicu closed 1 week ago

MadalinaRaicu commented 2 weeks ago

Related issues 🔗

Closes #6344

Description ℹī¸

Add market trading mode icons and tooltips to market page

Demo đŸ“ē

Screenshot 2024-05-02 at 14 42 21

Technical 👨‍🔧

Details of technical implementation that reviewers may need to be aware of, if applicable.

github-actions[bot] commented 2 weeks ago

Previews

App Preview
governance http://pr-6370.governance.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
explorer http://pr-6370.explorer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
trading http://pr-6370.trading.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
multisig-signer http://pr-6370.multisig-signer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
JonRay15 commented 2 weeks ago

I suspect I would prefer the solid icon here if I'm honest .... feels like its a bit easy to miss them at the moment if you're not actively looking.

image

MadalinaRaicu commented 1 week ago

I suspect I would prefer the solid icon here if I'm honest .... feels like its a bit easy to miss them at the moment if you're not actively looking.

image

updated

bwallacee commented 1 week ago

@MadalinaRaicu Theres no tool tip for the icon on the market selector. Also I wonder if it should allign with the perp pill. image

bwallacee commented 1 week ago

@MadalinaRaicu On the Markets page I think the time needed to hover over the icon before the tooltip displayed is too long, it feels like 2 seconds on my machine.

On the market selector the tooltip never displays on hover.

Are we doing the market type pill in another PR or has it been left out for a reason?

Note that as part of this we need to add the product pill to the new markets page as I have suddenly realised it is missing

bwallacee commented 1 week ago

I seem to be missing some icons: Proposed: image Trading Terminated: image

I feel like the icons could do with being a little bit bigger. The suspended one is quite hard to tell what it is: image

MadalinaRaicu commented 1 week ago

I seem to be missing some icons:

Proposed:

image

Trading Terminated:

image

I feel like the icons could do with being a little bit bigger. The suspended one is quite hard to tell what it is:

image

In market-sim please also assign the trading mode, not just the status. If you put trading mode NO_TRADING then the icons should appear. Usually market state alone doesn't tell us enough. It's the combination of the two.

MadalinaRaicu commented 1 week ago

@MadalinaRaicu Theres no tool tip for the icon on the market selector. Also I wonder if it should allign with the perp pill.

image

there's a lot going on there at the moment. will play a little bit with the alignment, unfortunately it cuts out the market code