I dont love the 3-dot button to bring down the filters ... could we not have a down arrow or maybe just have the "Filter proposals" be a button itself which then goes into a highlighted state when the filters drop down?
I also think the text entry should be at the top, but that is probably just preference so other views appreciated.
Type mappings
I also am surpised to see a couple of these types and think we should map multiple core types to a single type in a couple of cases ... namely:
[ ] Waiting for node vote map it to Open as it only applies to new assets and is logically no different to open to a user
[ ] Update spot market map to Update market
[ ] New spot market map to New market
Filters
Its a little strange to me that the filters are arranged across 3 columns when actually 2 of those related to the proposal types ... it feels like they're a third header / column but there's no header. I think it would be better to arrange it into two "rows" with the first being states and the second being types where both use the full width.
I also think we should reorder the proposal types so its easier to follow. So the final list (assuming still 3 columns would look like this
Include proposal states
Open Enacted Passed
Declined Failed Rejected
Include proposal types
New market Update market Update market state
New asset Update asset New transfer
Cancel transfer Update network param Update referral program
Update volume discount program Network upgrade New free form
Market update banner
Putting this here rather than making another ticket ... but we shoudl enhance that banner. Currently if there are multiple proposals open that may impact a market the banner just links to the proposals list, but now...
[ ] If multiple proposals are impacting a market the banner should link to the proposals page pre-filtered for proposals impacting the market (via URL filter string)
Tasks
Layout
I dont love the 3-dot button to bring down the filters ... could we not have a down arrow or maybe just have the "Filter proposals" be a button itself which then goes into a highlighted state when the filters drop down?
I also think the text entry should be at the top, but that is probably just preference so other views appreciated.
Type mappings
I also am surpised to see a couple of these types and think we should map multiple core types to a single type in a couple of cases ... namely:
Waiting for node votemap it toOpenas it only applies to new assets and is logically no different to open to a userUpdate spot marketmap toUpdate marketNew spot marketmap toNew marketFilters
Its a little strange to me that the filters are arranged across 3 columns when actually 2 of those related to the proposal types ... it feels like they're a third header / column but there's no header. I think it would be better to arrange it into two "rows" with the first being states and the second being types where both use the full width.
I also think we should reorder the proposal types so its easier to follow. So the final list (assuming still 3 columns would look like this
Market update banner
Putting this here rather than making another ticket ... but we shoudl enhance that banner. Currently if there are multiple proposals open that may impact a market the banner just links to the proposals list, but now...
Additional details / background info