vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
21 stars 14 forks source link

feat(trading): market page snags #6413

Closed MadalinaRaicu closed 2 weeks ago

MadalinaRaicu commented 2 weeks ago

Related issues 🔗

Closes #6316

Description ℹī¸

Demo đŸ“ē

image

Technical 👨‍🔧

Details of technical implementation that reviewers may need to be aware of, if applicable.

github-actions[bot] commented 2 weeks ago

Previews

App Preview
governance http://pr-6413.governance.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
explorer http://pr-6413.explorer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
trading http://pr-6413.trading.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
multisig-signer http://pr-6413.multisig-signer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
bwallacee commented 2 weeks ago

@MadalinaRaicu Open interest is still cut off for 13inch mac 100% zoom:

image

I don't think this has been done:

I think the font of the "primary" info in the table (market code, price etc) could be bigger to distinguish it more from the "secondary" grey info

This also hasn't been done:

It seems like the spark line graph doesn't fill the entire height of the row? The chart starts from maybe a third of the way up? But then it goes to the very top?

MadalinaRaicu commented 2 weeks ago

@MadalinaRaicu Open interest is still cut off for 13inch mac 100% zoom: image

I don't think this has been done:

I think the font of the "primary" info in the table (market code, price etc) could be bigger to distinguish it more from the "secondary" grey info

This also hasn't been done:

It seems like the spark line graph doesn't fill the entire height of the row? The chart starts from maybe a third of the way up? But then it goes to the very top?

  1. i previously enabled autosize on all the tables but it also saves the column widths if you dragged them. i think the open interest column width was saved previously on your computer so resetting console would make it work...but .now I have removed storing column preferences based on Matt's comment

  2. the font was slightly larger on market names, i don't think it looks very well on numerical fields. i have pushed now a change to make it slightly larger.

  3. the sparkline doesn't start from the third height of the row but from the middle and it is aligned with the 24h change values. i sort of left the sparkline changes out of this PR

MadalinaRaicu commented 2 weeks ago
Screenshot 2024-05-15 at 10 44 07