It seems that we need to be a bit more sophisticated in how we deal with the final status of batch proposals.
The issue is that in some cases like the image below the overall batch can pass - because the vote was successful - but then some parts of the batch can fail in the execution step.
In these cases the core status will remain on STATE_PASSED because the overall batch has indeed PASSED ... but if we just show this alone in the governance app it is quite misleading to users.
Accceptance Criteria
[ ] When a batch proposal has an overall status of STATE_PASSED
[ ] Check all subproposals for their individual statuses
[ ] If all proposals have STATE_PASSED then overall status shoudl remain "Passed"
[ ] If any proposal has <> STATE_PASSED
[ ] Display "Passed with errors" on the overall status in top right of card
[ ] Next to the overall status (Proposal passed: conditions met for X of X proposals) add text indicating "but some proposals failed in execution, expand for details"
[ ] In the vote breakdown display additional red text indicating that proposal failed in execution along with the errorDetails given by Core
[ ] In addition to this I think we should improve the colours on the overall status pill in the top right as I think currently they arent very intuitive:
[ ] Open proposals should be white
[ ] Passed & enacted proposals should be green
[ ] Declined or rejected proposals should be red
[ ] "Passed with errors" proposals as defined above should be yellow
[ ] If there are any other statuses found in implementation let me know
The Chore
It seems that we need to be a bit more sophisticated in how we deal with the final status of batch proposals.
The issue is that in some cases like the image below the overall batch can pass - because the vote was successful - but then some parts of the batch can fail in the execution step.
In these cases the core status will remain on STATE_PASSED because the overall batch has indeed PASSED ... but if we just show this alone in the governance app it is quite misleading to users.
Accceptance Criteria
errorDetails
given by CoreAdditional details / background info