vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
24 stars 14 forks source link

Ensure clarity around USDT Ethereum vs Arbitrum #6464

Closed JonRay15 closed 1 month ago

JonRay15 commented 2 months ago

The Chore

NB. I think we need to see where Art has got to with the cross asset flows before we can say for sure what needs to happen here so I want to see this in the wild asap.

Acceptance criteria

Trading screen

Deposit screen - Should be done by Art's PR

Withdraw screen - Should be done by Art''s PR

Cross chain deposit - Should be covered by #6507

Transfer screen

Portfolio screen

Rewards screen

Competitions screen

Additional details / background info

image

JonRay15 commented 1 month ago

I guess this info box needs to have the chain in brackets too?

image

And as per #6491 this should include both assets for spot markets ... but I dont think that is done yet.

JonRay15 commented 1 month ago

It feels strange to me that the only thing on this ticket that seems to support the chain ID is the size / notional switcher.

image

I think we tried to avoid putting it EVERYWHERE ... but in the USDT Arb v USDT Eth market you kind of need it or you just cant make sense of it. I suspect the right thing here is to have different behaviour on SPOT vs FUTR / PERP.

FUTR / PERP

SPOT: I think we want to add it bloody everywhere .... all across the deal ticket:

JonRay15 commented 1 month ago

We seem to have some recurrence of that weird "no accounts" bug appearing in the collateral table? Dont know if its related or just we havent noticed.

image