vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
23 stars 15 forks source link

feat(trading): distinguish between eth and arb assets #6521

Closed mattrussell36 closed 2 weeks ago

mattrussell36 commented 2 weeks ago

Related issues 🔗

Closes #6464

Description ℹī¸

Demo đŸ“ē

Screenshot 2024-06-10 at 15 31 04

Technical 👨‍🔧

Details of technical implementation that reviewers may need to be aware of, if applicable.

github-actions[bot] commented 2 weeks ago

Previews

App Preview
governance http://pr-6521.governance.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
explorer http://pr-6521.explorer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
trading http://pr-6521.trading.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
multisig-signer http://pr-6521.multisig-signer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
JonRay15 commented 2 weeks ago

Made various new comments on the origial ticket ... can we address these before merging please.

JonRay15 commented 2 weeks ago

We need it on deposit and withdrawal tabs .... its only on collateral right now.... but I think it probably is best to cover this on the PR for new arb deposits?

bwallacee commented 2 weeks ago

Should the asset details Source chain say Eth Sepolia (like it does for Arb Sepolia): image

Should we have a space after tUSDC?: image Missing chain on deposits and withdraws tables in portfolio: image

Should we have something to distinguish the chain the markets in order history are? (same for the other positions tabs) image

daro-maj commented 2 weeks ago

Do we need to specify chain also here ? image

daro-maj commented 2 weeks ago

Do we need to specify chain also here ? image

daro-maj commented 2 weeks ago

Is the governance is in the scope ? image