vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega

https://vega.xyz

MIT License

23 stars 15 forks source link

fix(trading): market icons snags #6525

Closed MadalinaRaicu closed 6 days ago

MadalinaRaicu commented 2 weeks ago

Related issues 🔗

Closes #6287

Description ℹ️

[x] center all pills and icons
[x] enable emblem for markets to have different sizes
[x] adjust fees market cells
[x] if market emblem is smaller, then chain icons need to have their position adjusted, come with set sizes

Demo 📺

Technical 👨‍🔧

Details of technical implementation that reviewers may need to be aware of, if applicable.

github-actions[bot] commented 2 weeks ago

Previews

App	Preview
governance	http://pr-6525.governance.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
explorer	http://pr-6525.explorer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
trading	http://pr-6525.trading.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com
multisig-signer	http://pr-6525.multisig-signer.previews.vega.rocks.s3-website.eu-west-1.amazonaws.com

edd commented 1 week ago

Tested on the deploy preview, looks like it's working nicely.

One question I have is why https://github.com/vegaprotocol/frontend-monorepo/pull/6525/files#diff-cb3dfb1f734245233f203c9072dea69719913f6e1533f51c433100f6d37b347cR12 has been added? Not very important, but I haven't seen what else in this PR makes it neccessary.

Answer: to import classnames