vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
23 stars 15 forks source link

Improve message on Arbitrum deposit toast #6528

Closed JonRay15 closed 3 hours ago

JonRay15 commented 2 weeks ago

The Chore

We get stuck on this for a long time

image

Acceptance criteria

There is a Core discussion about whether actually we can just use latest status on Arbbitrum and if we can then all this goes away because they will be pretty much instant.

If not ... we've now talked through the fact that we can call eth_getBlockByNumber() every say 30s with each of latest, finalized, and safe and we'll be able to provide a kind of countdown on the toast and the deposit table. See additional details for more. (NB. simplified this logic now with a more basic flow)

Additional details / background info

New simplified logic

Previous logic

Docs

https://docs.arbitrum.io/for-devs/troubleshooting-building#how-many-block-numbers-must-we-wait-for-in-arbitrum-before-we-can-confidently-state-that-the-transaction-has-reached-finality

JonRay15 commented 3 hours ago

Core decision to use "Latest" means this iis not really needed once next core release is in.

Not worth doing for the sake of 3 weeks.