search

vegaprotocol / pennant

A charting library for Vega Console
https://pennant.vega.xyz
MIT License
25 stars 8 forks source link

Price annotation and candles get out of sync #833

Closed mattrussell36 closed 9 months ago

mattrussell36 commented 1 year ago

Description

After some period of time the price annotation gets out of sync with the last candle. Additionally the decimal precision is lost.

Steps to Reproduce

  1. Open a candle chart
  2. Wait
  3. Use market sim to try to increment time to try to reproduce this
  4. Eventually notice that the price annotation does not align with the last price on a candle

Expected behavior

Price annotation should match the closing price of the latest candle

Screenshots

image (2)

Additional context

https://vegaprotocol.slack.com/archives/C037STCKMGC/p1685903922105259

macqbat commented 11 months ago

Cannot reproduce it. Possible, it was fixed in some other previous works. Can you QA guys can confirm it?

bwallacee commented 9 months ago

I can't recreate this using market-sim so far. I'm not sure if we want to close this issue or just icebox it for now? cc @JonRay15 , @mattrussell36

JonRay15 commented 9 months ago

We cannot reproduce and think this likely will have been fixed by the change to use the last candle when Core changed their retention policy on the candles API. Closing this.