feat: redefine data source protos

AnExsomnis commented 2 years ago

close vegaprotocol/vega#5714

This PR redefines the proto types related to oracles following the logic presented in https://github.com/vegaprotocol/specs/pull/1161

changes introduced:

For all external data sources - we care about pubkeys and filters -> so we apply same properties for all (this follows the logic in https://github.com/vegaprotocol/specs/pull/1161) => Everywhere where we have oracle definitions we use the generic data source type instead of custom oracle type
There is an option where we can embed generic data type into the oracle type - if we really need specific properties for oracles. Same of course can be applied further for different groups of oracles (ETH, or not), bridges as a separate group of external sources, whatever we would need.

The idea behind the changes is:

use a way as straight forward as possible (doing the correct thing is not always the simplest change)
do not involve the design with any workaround -> if a workaround is needed - isolate it from the design, so when it needs to be removed - it will not harm the idea.
have generic types on early stage (like now) ad build up on them if you have to

AnExsomnis commented 2 years ago

Just the commands might need updating relative to these changes.

@jeremyletang , Addressed all of your comments and rebased with develop

jeremyletang commented 2 years ago

Those changes looks good to me @AnExsomnis, let's move them over onto the vega repo on a new PR please. thanks.

gordsport commented 2 years ago

closing as done in:

vegaprotocol / protos