edd commented 4 years ago

Before tagging

[x] Merge fix for unreleased funds
[x] Merge fix for displayed fees
[x] Merge market depth improvements
[x] Merge GraphQL API for events
[x] Fix #2251 - order count incorrect
[x] Fix #2253 - multi-threaded access to market depth
[x] Fix auction uncrossing
[ ] ~Merge feature for loading more config from genesis~ Delayed to #2295

After tagging

[x] Add changelog to this message

QA Validation of release

[ ] System-tests must pass
[ ] QA bash tests must pass (Currently -> qa bash tests)
[x] Bulk order cancel (#36)
[x] Margin accounts funds are release each time a position goes back 0 (#2239)
[ ] Add fees payed by distressed traders in the trade between distressed trader and the network (#2237)
[x] GQL call to expose the event streams (#2205)
[ ] Missing order count in market depth (#2251)

Release

[x] Push pre-tagged release to staging
[x] Push tagged release to staging
[x] Push tagged release to testnet

Previous: https://github.com/vegaprotocol/vega/issues/2146

Changelog

0.25.0

2020-09-24

This release adds the event bus API, allowing for much greater introspection in to the operation of a node. We've also re-enabled the order amends API, as well as a long list of fixes.

New

#2281 Enable opening auctions
#2205 Add GraphQL event stream API
#2219 Add deposits API
#2222 Initial asset list is now loaded from genesis configuration, not external configuration
#2238 Re-enable order amend API
#2249 Re-enable TX rate limit by party ID
#2240 Add timestamp to position responses

Improvements

#2211 🔥 GraphQL: Field case change proposalId -> proposalID
#2218 🔥 GraphQL: Withdrawals now return a Party, not a party ID
#2202 Fix timestamp validation for proposals when all timestamps are the same
#2206 Reduce log noise from statistics endpoint
#2207 Automatically reload node configuration
#2209 GraphQL: fix proposal rejection enum
#2210 Refactor order service to not require blockchain client
#2213 Improve error clarity for invalid proposals
#2216 Ensure all GRPC endpoints use real time, not Vega time
#2231 Refactor processor to no longer require collateral
#2232 Clean up logs that dumped raw bytes
#2233 Remove generate method from execution engine
#2234 Remove authEnabled config setting
#2236 Simply order amendment logging
#2237 Clarify fees attribution in transfers
#2239 Ensure margin is released immediately, not on next mark to market
#2241 Load log level in processor app
#2245 Fix a concurrent map access in positions API
#2247 Improve logging on a TX with an invalid signature
#2252 Fix incorrect order count in Market Depth API
#2254 Fix concurrent map access in Market Depth API
#2269 GraphQL: Fix party filtering for event bus API
#2266 Refactor transaction codec
#2275 Prevent opening auctions from closing early
#2262 Clear potential position properly when an order is cancelled for self trading
#2286 Add sequence ID to event bus events
#2288 Fix auction events not appearing in GraphQL event bus
#2294 Fixing incorrect order iteration in auctions
#2285 Check auction times
#2283 Better handling of 0 expiresAt

edd commented 4 years ago

Note that the GQL event stream currently has quite a few open issues (#2256, #2258, #2259 #2260, #2261, ...) which make it not really ready for prime time. However I do not believe this is realted to the underlying GRPC stream, so I don't consider this a blocker- we can say in the changelog that it is not ready for use, if it isn't fixed when we want to tag. As it's a new API this isn't a regression, so I think it's reasonable to say 'This exists, but will change shortly and may not act as expected.'

nzbaen commented 4 years ago

:white_check_mark: Margin account funds released when position goes back to 0

Validated using: multiple_orders.sh and positions.sh scripts

Run multiple_orders.sh (./multiple_orders.sh devnet.dom) to submit a number of orders and opening position(s)
Run positions.sh (./positions.sh devnet.dom) to check on the open positions, the balance, close the open position, validate that the Margin account is = 0 once the position is closed.

Tests passed correctly

nzbaen commented 4 years ago

:white_check_mark: Bulk order cancellation

Validated using: multiple_orders_active.sh and cancel_order.sh

Run multiple_orders_active.sh (./multiple_orders_active.sh devnet.dom) to submit a number of orders with static price/size (100/1000)
Run cancel_order.sh (./cancel_order.sh devnet.dom -a the -a option is to cancel all the orders for the partyID) to cancel all the orders

Tests passed correctly

edd commented 4 years ago

Tentative changelog

0.25.0

2020-09-24 This release adds the event bus API, allowing for much greater introspection in to the operation of a node. We've also re-enabled the order amends API, as well as a long list of fixes.

New

#2281 Enable opening auctions
#2205 Add GraphQL event stream API
#2219 Add deposits API
#2222 Initial asset list is now loaded from genesis configuration, not external configuration
#2238 Re-enable order amend API
#2249 Re-enable TX rate limit by party ID
#2240 Add timestamp to position responses

Improvements

#2211 🔥 GraphQL: Field case change proposalId -> proposalID
#2218 🔥 GraphQL: Withdrawals now return a Party, not a party ID
#2202 Fix timestamp validation for proposals when all timestamps are the same
#2206 Reduce log noise from statistics endpoint
#2207 Automatically reload node configuration
#2209 GraphQL: fix proposal rejection enum
#2210 Refactor order service to not require blockchain client
#2213 Improve error clarity for invalid proposals
#2216 Ensure all GRPC endpoints use real time, not Vega time
#2231 Refactor processor to no longer require collateral
#2232 Clean up logs that dumped raw bytes
#2233 Remove generate method from execution engine
#2234 Remove authEnabled config setting
#2236 Simply order amendment logging
#2237 Clarify fees attribution in transfers
#2239 Ensure margin is released immediately, not on next mark to market
#2241 Load log level in processor app
#2245 Fix a concurrent map access in positions API
#2247 Improve logging on a TX with an invalid signature
#2252 Fix incorrect order count in Market Depth API
#2254 Fix concurrent map access in Market Depth API
#2269 GraphQL: Fix party filtering for event bus API
#2266 Refactor transaction codec
#2275 Prevent opening auctions from closing early
#2262 Clear potential position properly when an order is cancelled for self trading
#2286 Add sequence ID to event bus events
#2288 Fix auction events not appearing in GraphQL event bus
#2294 Fixing incorrect order iteration in auctions
#2285 Check auction times
#2283 Better handling of 0 expiresAt

nzbaen commented 4 years ago

@edd @3jtechtest Those are the updated tasks for QA to validate v0.25.0 can you please confirm and add/modify/remove if necessary? Thanks

QA Validation of release

[x] System-tests must pass
[ ] QA bash tests must pass (Currently -> qa bash tests)
[x] (QA #36) Bulk order cancel
[x] (QA #39) Margin accounts funds are release each time a position goes back 0
[x] (QA #40) Add fees paid by distressed traders in the trade between distressed trader and the network
[x] (QA #41) GQL call to expose the event streams
[x] (QA #42) Missing order count in market depth
[x] (QA #43) Add deposits API
[x] (QA #44) Initial asset list is now loaded from genesis configuration, not external configuration
[x] (QA #45) Re-enable order amend API
[x] (QA #46) Fix timestamp validation for proposals when all timestamps are the same
[ ] (QA #47) GraphQL: fix proposal rejection enum
[x] (QA #48) Improve error clarity for invalid proposals
[x] (Core #2281) Enable opening auctions
[x] (Core #2216) Ensure all GRPC endpoints use real time, not Vega time
[x] (Core #2211) GraphQL: Field case change proposalID -> proposalId
[x] (Core #2218) GraphQL: Withdrawals now return a Party, not a party ID
[x] (Core #2236) Simply order amendment logging
[x] (Core #2245) Fix a concurrent map access in positions API
[x] (Core #2245) Improve logging on a TX with an invalid signature x

edd commented 4 years ago

@domvega this changelog is now finalised

nzbaen commented 4 years ago

@edd we are good to go for v0.25.0. @3jtechtest please leave here your comment on it.

For the others, please vote: 👍 - Good to go 👎 - Problems (please explain) 🎉 - Release the Kraken... I mean v0.25.0

edd commented 4 years ago

Note for historical purposes: We still have https://github.com/vegaprotocol/vega/issues/1965 as an ongoing issue in 0.25.0. I have voted 👍 in spite of this as:

It's not a regression in this release
We have once again confirmed that it is not a fault in the order book, just the market depth response

nzbaen commented 4 years ago

Continuing on the Note for historical purpose #1965 I'd just like to add that I've ran few check on the market spread during last night and today and all the time the script found the negative spread (as reported in Zabbix too) the order book had correct data with no negative spread, but the negative spread was reported in the market depth

vegaprotocol / vega

Tag 0.25.0 #2243

Before tagging

After tagging

QA Validation of release

Release

Changelog

0.25.0

New

Improvements

0.25.0

New

Improvements

QA Validation of release