search

vegaprotocol / vega

A Go implementation of the Vega Protocol, a protocol for creating and trading derivatives on a fully decentralised network.
https://vega.xyz
GNU Affero General Public License v3.0
37 stars 22 forks source link

bots unable to place order on dev #410

Closed ashleyvega closed 4 years ago

ashleyvega commented 4 years ago

In GitLab by @jeremyletang on Aug 15, 2019, 16:19

We return an error when not getting any risk updates from the risk engine. May need to change the api a little in the future so we return a slice of event and an error from the function as at the moment we were expecting it to be an error when no event are return.

Aug 15 10:50:50 devnet-london-y5m2a vega[1682]: 2019-08-15T10:50:50.219Z    ERROR   blockchain  blockchain/service.go:179   error message on creating order {"order": "id:\"V0000000629-0000009569\" marketID:\"4ABBL4JPPV3LZNCNXSJKUBNNYXUNYYMS\" partyID:\"t-GBPEUR-DEC19-000176\" price:104 size:50 remaining:50 type:GTT createdAt:1565866248927325059 expiresAt:1565866848493843787 reference:\"ff03cd1a-0e45-44b4-ac1b-8cd55d9f6f19\" ", "error": "margin check failed", "errorVerbose": "margin check failed\ncode.vegaprotocol.io/vega/internal/execution.init\n\t/builds/vega-protocol/trading-core/go/src/internal/execution/market.go:32\ncode.vegaprotocol.io/vega/internal/config.init\n\t<autogenerated>:1\nmain.init\n\t<autogenerated>:1\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:189\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1333"}
Aug 15 10:50:50 devnet-london-y5m2a vega[1682]: 2019-08-15T10:50:50.219Z    ERROR   blockchain  blockchain/abci.go:214  Error when validating payload in DeliverTx  {"error": "margin check failed", "errorVerbose": "margin check failed\ncode.vegaprotocol.io/vega/internal/execution.init\n\t/builds/vega-protocol/trading-core/go/src/internal/execution/market.go:32\ncode.vegaprotocol.io/vega/internal/config.init\n\t<autogenerated>:1\nmain.init\n\t<autogenerated>:1\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:189\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1333"}
Aug 15 10:50:50 devnet-london-y5m2a vega[1682]: 2019-08-15T10:50:50.219Z    WARN    execution   execution/market.go:494 No risk updates after call to Update Margins in collateralAndRisk()
Aug 15 10:50:50 devnet-london-y5m2a vega[1682]: 2019-08-15T10:50:50.219Z    ERROR   execution   execution/market.go:445 Invalid number of risk updates  {"market-id": "4ABBL4JPPV3LZNCNXSJKUBNNYXUNYYMS", "risk-updates-count": 0}
Aug 15 10:50:50 devnet-london-y5m2a vega[1682]: 2019-08-15T10:50:50.219Z    ERROR   execution   execution/market.go:320 Unable to check/add margin for trader   {"error": "unable to get risk updates", "errorVerbose": "unable to get risk updates\ncode.vegaprotocol.io/vega/internal/execution.(*Market).checkMarginForOrder\n\t/builds/vega-protocol/trading-core/go/src/internal/execution/market.go:449\ncode.vegaprotocol.io/vega/internal/execution.(*Market).SubmitOrder\n\t/builds/vega-protocol/trading-core/go/src/internal/execution/market.go:313\ncode.vegaprotocol.io/vega/internal/execution.(*Engine).SubmitOrder\n\t/builds/vega-protocol/trading-core/go/src/internal/execution/engine.go:261\ncode.vegaprotocol.io/vega/internal/blockchain.(*abciService).SubmitOrder\n\t/builds/vega-protocol/trading-core/go/src/internal/blockchain/service.go:156\ncode.vegaprotocol.io/vega/internal/blockchain.(*Processor).Process\n\t/builds/vega-protocol/trading-core/go/src/internal/blockchain/processor.go:135\ncode.vegaprotocol.io/vega/internal/blockchain.(*AbciApplication).DeliverTx\n\t/builds/vega-protocol/trading-core/go/src/internal/blockchain/abci.go:212\ngithub.com/tendermint/tendermint/abci/server.(*SocketServer).handleRequest\n\t/builds/vega-protocol/trading-core/go/pkg/mod/github.com/tendermint/tendermint@v0.31.5/abci/server/socket_server.go:181\ngithub.com/tendermint/tendermint/abci/server.(*SocketServer).handleRequests\n\t/builds/vega-protocol/trading-core/go/pkg/mod/github.com/tendermint/tendermint@v0.31.5/abci/server/socket_server.go:163\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1333", "market-id": "4ABBL4JPPV3LZNCNXSJKUBNNYXUNYYMS"}
ashleyvega commented 4 years ago

In GitLab by @jeremyletang on Aug 15, 2019, 16:19

assigned to @jeremyletang

ashleyvega commented 4 years ago

In GitLab by @ashleyvega on Aug 20, 2019, 18:53

changed the description

ashleyvega commented 4 years ago

In GitLab by @cdm on Aug 28, 2019, 07:29

IIRC this was fixed, as it was critical, please can you comment/close if so @jeremyletang ?

ashleyvega commented 4 years ago

In GitLab by @ashleyvega on Aug 30, 2019, 14:25

@jeremyletang :point_up: Is there anything to be done regarding this Issue?

ashleyvega commented 4 years ago

In GitLab by @jeremyletang on Aug 30, 2019, 14:26

well this was fixed I believe.

ashleyvega commented 4 years ago

In GitLab by @jeremyletang on Aug 30, 2019, 14:26

closed