vegaprotocol / vega

A Go implementation of the Vega Protocol, a protocol for creating and trading derivatives on a fully decentralised network.
https://vega.xyz
GNU Affero General Public License v3.0
36 stars 22 forks source link

Add extra validation to the protocol_upgrade_proposal command #8548

Closed gordsport closed 1 year ago

gordsport commented 1 year ago

When the validators submitted the protocol_upgrade_proposal command for the patch release to 0.71.6.

Command used:

vega protocol_upgrade_proposal --home <YOUR_VEGA_HOME> --vega-release-tag v0.71.6 --height 3917600

Error message presented:

failed to get commander: couldn't initialise ABCI client: abci client addr is empty in config

This is believed to be due to the fact the Tendermint/cometBFT config is not complete.

Van we validate this earlier so that the validators can fix sooner, also is there any way to default to a known config in order for this command to be successful yet still advise they update.

jeremyletang commented 1 year ago

2 things to be done here: