vegaprotocol / vega

A Go implementation of the Vega Protocol, a protocol for creating and trading derivatives on a fully decentralised network.
https://vega.xyz
GNU Affero General Public License v3.0
36 stars 22 forks source link

[Bug]: Transaction can be approved in vega wallet before any transaction is submitted #9117

Open daniel1302 opened 1 year ago

daniel1302 commented 1 year ago

Problem encountered

Bug found in the vega wallet by Ed from the Validator group

Observed behaviour

Forwarded message from the Validators discord

I found an interesting "bug" in the CLI wallet. I guess it's less of a bug but if you hit y then enter while the wallet is idling and connected, next time you submit a tx it will get approved immediately, presumably because the y is still waiting in stdin and gets read as soon as the tx requires confirmation.

Expected behaviour

This needs to be discussed

Steps to reproduce

1. Start wallet
2. Press the "y" when no transaction needs to be approved
3. Send any transaction

Software version

v0.71.6 - ubuntu 22 amd64

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

ValentinTrinque commented 1 year ago

It's known.