vegaprotocol / vegawallet-browser

https://vegaprotocol.github.io/vegawallet-browser/
MIT License
3 stars 1 forks source link

SPIKE: Transaction naming and the actions that get you there #231

Open ckpringle opened 1 year ago

ckpringle commented 1 year ago

The Spike

Most transaction names no longer map to the action you've taken in a dapp. The experience would be better if the names were improved where it makes sense to. This spike is to work out what, if anything, we want to do to improve the experience from dapp to wallet transaction whilst making sure anyone making their own dapps can still recognise the commands.

For example

Action in UI: Transaction title

Place order: OrderSubmission Cancel order: OrderCancellation Edit order: OrderAmendment Release funds: WithdrawSubmission Remove stake: UndelegateSubmission Transfer: Transfer(!)

Questions we need to answer

Tasks

Notes

barnabee commented 1 year ago

Renaming the commands isn't really on the cards.

In most of the examples given in the ticket, from an API (which is what the commands are) perspective, the current commands are better named than the front end actions.

Also note that there is not always a 1:1 mapping between action and command, for example "close position" doesn't (and won't) have a command of it's own. So I'm not sure it would be a goal/possible to match UI terms and API commands.

There is a question whether to have some special interpretation/hints to allow commands used in certain ways or from certain freont ends to be displayed in the wallet in a specific way related to the action being attempted. This is something wallets like Metamask do, for instance on token approvals, but that seems well beyond MVP to me.