search

vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

test: report where ac coverage has increased and decreased in a comment #597

Closed dalebennett1992 closed 1 year ago

dalebennett1992 commented 1 year ago

PR to report in which files ac has decreased, increased and new files. Displays a warning if coverage has decreased in files when compared to main.

This currently fails due to bug in approbation. I have a PR open here. Will pick this up when it goes down

dalebennett1992 commented 1 year ago

Here is what comments will look like for diff ac outcomes:

no changes:

image

increase in coverage only (observe no warning):

image

decrease in coverage only:

image

decrease and an increase in coverage:

image

github-actions[bot] commented 1 year ago

Here is your approbation coverage BEFORE this PR:

*Criteria*: 187  *Covered*: 181  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 96.8%

Here is your approbation coverage AFTER this PR:

*Criteria*: 187  *Covered*: 181  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 96.8%

AC Diff Report:

There are no changes to AC coverage %, please note any new coverage is ignored by this report IF it retains a 100% coverage for the given file.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information