vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

feat(418): cancel order 2nd pass #624

Closed sam-keen closed 1 year ago

sam-keen commented 1 year ago

Updated receipt view for cancel orders.

Screenshot 2023-10-24 at 13 00 28

Edge cases for when an order is omitted or the order and market are omitted are handled like so:

Screenshot 2023-10-18 at 10 31 55 Screenshot 2023-10-18 at 10 32 30
github-actions[bot] commented 1 year ago

Here is your approbation coverage BEFORE this PR:

*Criteria*: 206  *Covered*: 200  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.1%

Here is your approbation coverage AFTER this PR:

*Criteria*: 221  *Covered*: 215  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.3%

AC Diff Report:

New spec files and their coverage:

1119-ORBD-order_badges.md 100% coverage
1130-ODTB-order_table.md 100% coverage
dalebennett1992 commented 1 year ago

test evidence: For a missing order id, this looks ok. image

Error warning misleading when order does not exist image

Should we have something specific to the order not being present instead of this

Error for a market id that does not exist

image

I think we should have more specific handling than bombing out here.

Bombing out when neither id is populated

image

Again - should have specific handling. If I am not mistaken in the PR description we actually describe this scenario as having some handling around it so I think this is a bug?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

emilbayes commented 1 year ago

Merged in https://github.com/vegaprotocol/vegawallet-browser/commit/44a8e573bc05174bf4bcd5c5d6f89fb002155e01