Closed dexturr closed 9 months ago
Here is your approbation coverage BEFORE this PR:
All ACs: *Criteria*: 278 *Covered*: 271 *by/FeatTest*: - *by/SysTest*: - *Uncovered*: 7 *Coverage*: 97.5%
Here is your approbation coverage AFTER this PR:
All ACs: *Criteria*: 296 *Covered*: 286 *by/FeatTest*: - *by/SysTest*: - *Uncovered*: 10 *Coverage*: 96.6%
Spec files decreased in % coverage:
1138-EXRP-export_recovery_phrase.md by 13.00%
New spec files and their coverage:
1138-NWST-network_settings.md 100% coverage
1142-NWSW-network_switching.md 75% coverage
You have files with decreased AC coverage. This should not be happening. Please investigate the following files:
1138-EXRP-export_recovery_phrase.md
link for docs does not work for fairground and mainnet
Why do we have linked nodes if each one returns an error ?
We have error during submit an order and switching the margin mode
Error: Market with id a79834ef7d9019a60821d4962fc2561663a2558011dc9ed972ab8b01381e8d10 not found at getMarketById (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:109461:20) at VegaMarket (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:111022:21) at renderWithHooks (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:24368:20) at updateFunctionComponent (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:27646:22) at beginWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:29659:18) at beginWork$1 (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:35469:16) at performUnitOfWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34603:14) at workLoopSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34509:7) at renderRootSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34477:9) at recoverFromConcurrentError (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:33894:22)
We have error during submit an order and switching the margin mode
Error: Market with id a79834ef7d9019a60821d4962fc2561663a2558011dc9ed972ab8b01381e8d10 not found at getMarketById (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:109461:20) at VegaMarket (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:111022:21) at renderWithHooks (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:24368:20) at updateFunctionComponent (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:27646:22) at beginWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:29659:18) at beginWork$1 (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:35469:16) at performUnitOfWork (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34603:14) at workLoopSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34509:7) at renderRootSync (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:34477:9) at recoverFromConcurrentError (chrome-extension://niochpahfbnajmdfmbnekhajmhofchog/popup.js:33894:22)
Is tracked by this ticket: https://github.com/vegaprotocol/vegawallet-browser/issues/625
Why do we have linked nodes if each one returns an error ?
Yes this is correct, these are the nodes so in order to interact with them you'd need to use https://docs.vega.xyz/testnet/api/rest/overview to figure out what end points you want to query etc.
The SonarCloud Quality Gate passed, but some issues were introduced.
11 New issues
0 Security Hotspots
100.0% Coverage on New Code
1.6% Duplication on New Code
Closes #677 Closes #695