search

vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

Chore/conditional datatable #714

Closed dexturr closed 9 months ago

dexturr commented 9 months ago

Add ConditionalDataTable component to reduce repeated logic in receipt views and reduce branches

github-actions[bot] commented 9 months ago

Here is your approbation coverage BEFORE this PR:

All ACs: *Criteria*: 303  *Covered*: 292  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 11  *Coverage*: 96.4%

Here is your approbation coverage AFTER this PR:

All ACs: *Criteria*: 305  *Covered*: 296  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 9  *Coverage*: 97.0%

AC Diff Report:

Spec files Increased in % coverage:

1142-NWSW-network_switching.md by 25.00%
sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud