vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

chore: add some buffer height as firefox no longer seems to respect resize #721

Closed dexturr closed 8 months ago

dexturr commented 9 months ago

When the popout was opened on MacOS in Firefox the nav buttons were partially off the screen. This fixes that, ensure that the buttons are now shown.

github-actions[bot] commented 9 months ago

Here is your approbation coverage BEFORE this PR:

All ACs: *Criteria*: 305  *Covered*: 296  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 9  *Coverage*: 97.0%

Here is your approbation coverage AFTER this PR:

All ACs: *Criteria*: 305  *Covered*: 296  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 9  *Coverage*: 97.0%

AC Diff Report:

There are no changes to AC coverage %, please note any new coverage is ignored by this report IF it retains 100% coverage for the given file.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud