fix: order cancellation view

vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.

https://vegaprotocol.github.io/vegawallet-browser/

MIT License

4 stars 1 forks source link

fix: order cancellation view #819

Closed dexturr closed 5 months ago

dexturr commented 5 months ago

Order cancellation view had bugs in the form of potential race conditions when in pop-out mode and not rendering some messages correctly when a mass order cancellation was present. This PR also tidies some thing up to make the implementation simplier to grok.

github-actions[bot] commented 5 months ago

Here is your approbation coverage BEFORE this PR:

All ACs: *Criteria*: 352  *Covered*: 338  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 14  *Coverage*: 96.0%

Here is your approbation coverage AFTER this PR:

All ACs: *Criteria*: 352  *Covered*: 338  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 14  *Coverage*: 96.0%

AC Diff Report:

There are no changes to AC coverage %, please note any new coverage is ignored by this report IF it retains 100% coverage for the given file.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud