vegaprotocol / vegawallet-desktop

Desktop application for Vega Protocol's wallet
MIT License
15 stars 12 forks source link

Linux build does not have an icon #160

Closed edd closed 1 year ago

edd commented 2 years ago

Latest develop branch, as of filing this message, built with Wails CLI v2.0.0-beta.32, running Ubuntu / Gnome - the app has no icon.

I don't consider this a blocker for release.

image

❯ wails build -f -clean
Wails CLI v2.0.0-beta.32

App Type:               desktop
Platforms:              linux/amd64
Compiler:               /usr/bin/go
Build Mode:             Production
Skip Frontend:          false
Compress:               false
Package:                true
Clean Build Dir:        true
LDFlags:                ""
Tags:                   []

Building target: linux/amd64
----------------------------
  - Installing frontend dependencies:     
    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: 'vegawallet@0.1.0+dev',
    npm WARN EBADENGINE   required: { node: '^16.13.2' },
    npm WARN EBADENGINE   current: { node: 'v17.5.0', npm: '8.4.1' }
    npm WARN EBADENGINE }
    npm WARN deprecated source-map-resolve@0.6.0: See https://github.com/lydell/source-map-resolve#deprecated
    npm WARN deprecated debug@4.2.0: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
    npm ERR! code ERR_SOCKET_TIMEOUT
    npm ERR! network Socket timeout
    npm ERR! network This is a problem related to network connectivity.
    npm ERR! network In most cases you are behind a proxy or have bad network settings.
    npm ERR! network 
    npm ERR! network If you are behind a proxy, please make sure that the
    npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

    npm ERR! A complete log of this run can be found in:
    npm ERR!     /home/edd/.npm/_logs/2022-02-23T11_46_54_432Z-debug-0.log

Error: %!(EXTRA string=exit status 1)

If Wails is useful to you or your company, please consider sponsoring the project:
https://github.com/sponsors/leaanthony

vegawallet-desktop on  develop [!] via 🐹 v1.17 took 15s 
❯ nvm use 16
Now using Node v16.14.0 (npm 8.3.1) ~/.local/share/nvm/v16.14.0/bin/node

vegawallet-desktop on  develop [!] via 🐹 v1.17 
❯ wails build -f -clean
Wails CLI v2.0.0-beta.32

App Type:               desktop
Platforms:              linux/amd64
Compiler:               /usr/bin/go
Build Mode:             Production
Skip Frontend:          false
Compress:               false
Package:                true
Clean Build Dir:        true
LDFlags:                ""
Tags:                   []

Building target: linux/amd64
----------------------------
  - Installing frontend dependencies: Done.
  - Compiling frontend: Done.
  - Compiling application: go: downloading code.vegaprotocol.io/shared v0.0.0-20220202150846-b6aba31dcdb0
go: downloading code.vegaprotocol.io/vegawallet v0.12.1-0.20220215193236-62a1689f606f
go: downloading go.uber.org/zap v1.20.0
go: downloading github.com/BurntSushi/toml v1.0.0
go: downloading code.vegaprotocol.io/protos v0.48.1-0.20220209133852-0f31e2fef5ff
go: downloading github.com/stretchr/testify v1.7.0
go: downloading github.com/golang/mock v1.4.3
go: downloading github.com/golang/protobuf v1.5.2
go: downloading go.uber.org/atomic v1.7.0
go: downloading go.uber.org/multierr v1.6.0
go: downloading go.uber.org/goleak v1.1.11
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/google/go-cmp v0.5.5
go: downloading github.com/leaanthony/winc v0.0.0-20220208061147-37b059b9dc3b
go: downloading github.com/matryer/is v1.4.0
go: downloading google.golang.org/protobuf v1.26.0
go: downloading github.com/benbjohnson/clock v1.1.0
go: downloading github.com/leaanthony/typescriptify-golang-structs v0.1.7
go: downloading github.com/leaanthony/go-webview2 v1.0.3-0.20220125181555-00f20a61c17d
go: downloading github.com/gofiber/fiber/v2 v2.17.0
go: downloading github.com/gofiber/websocket/v2 v2.0.8
go: downloading github.com/leaanthony/go-ansi-parser v1.0.1
go: downloading github.com/leaanthony/go-common-file-dialog v1.0.3
go: downloading github.com/gabriel-vasile/mimetype v1.3.1
go: downloading github.com/fasthttp/websocket v0.0.0-20200320073529-1554a54587ab
go: downloading github.com/valyala/fasthttp v1.28.0
go: downloading github.com/tkrajina/go-reflector v0.5.5
go: downloading github.com/go-ole/go-ole v1.2.6
go: downloading github.com/jchv/go-winloader v0.0.0-20210711035445-715c2860da7e
go: downloading github.com/google/uuid v1.1.2
go: downloading github.com/savsgio/gotils v0.0.0-20200117113501-90175b0fbe3f
go: downloading github.com/valyala/tcplisten v1.0.0
go: downloading github.com/klauspost/compress v1.12.2
go: downloading github.com/andybalholm/brotli v1.0.2
go: downloading github.com/valyala/bytebufferpool v1.0.0
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/dgrijalva/jwt-go v3.2.0+incompatible
Done.
  - Packaging application: Done.
Built '/home/edd/src/vega/vegawallet-desktop/build/bin/Vegawallet' in 43.134s.

If Wails is useful to you or your company, please consider sponsoring the project:
https://github.com/sponsors/leaanthony
ValentinTrinque commented 2 years ago

This requires to distribute a .desktop file and the icon file along with the software. The .desktop file requires some paths to be set to locate the executable and icon files. The cleanest way to provide is to create an Linux installer of some sort.

Contribution welcome.

pennyandrews commented 2 years ago

If we do something for this we should consider doing it as a wails contribution rather than just handling in the wallet

pennyandrews commented 2 years ago

If we do something for this we should consider doing it as a wails contribution rather than just handling in the wallet