vegaprotocol / vegawallet-desktop

Desktop application for Vega Protocol's wallet
MIT License
15 stars 12 forks source link

Switch quickly network can corrupt the application configuration #498

Closed ValentinTrinque closed 1 year ago

ValentinTrinque commented 1 year ago

When switching network to fast by spamming the button, the “DefaultNetwork” get overwritten so fast that the file is left with previous character, corrupting the file.

We should prevent the user to trigger that update to fast.

Screenshot 2023-02-17 at 14 02 25

Notice the extra e at the end, probably from the false value of a previous config.

radoslaw-szpiech commented 1 year ago

Also, there is connected issue with that If you you switch path to config catalog, that does not exist, you get screen as below: image At this point:

EDIT: Also, the path on this screen is not the one that I used.

radoslaw-szpiech commented 1 year ago

UPDATE: It looks like it cannot be reproduced just by switching to not existing catalog, as it just creates new catalog then. It was fixed during writing my comment, or I was just unlucky to experience that. There is still valid issue, if we use Path, that cannot be simply accessed by User - https://github.com/vegaprotocol/vegawallet-desktop/issues/504

ValentinTrinque commented 1 year ago

This is done.