search

vegaprotocol / vegawallet-desktop

Desktop application for Vega Protocol's wallet
MIT License
15 stars 12 forks source link

Cannot edit network configuration #588

Closed radoslaw-szpiech closed 1 year ago

radoslaw-szpiech commented 1 year ago

Description

There is error visible each time user tries to submit network changes. It's not possible to save changes.

It breaks existing AC - 0001-WALL-011

When fixed, please unskip network-configuration tests in vegawallet-desktop repo.

Steps to Reproduce

  1. Open app
  2. Click networks arrow
  3. Click Manage networks
  4. Choose any network and click Edit
  5. Provide any change (e.g. add dApp address or modify nodes address)
  6. Try to submit changes <- Error is visible

Expected behavior

Changes are saved without any error.

Screenshots

Screenshot 2023-03-28 at 12 10 38

ValentinTrinque commented 1 year ago

This is a core bug that will be fixed when 0.71.0 will be merged.

ValentinTrinque commented 1 year ago

Also the metadata edition is missing. We need to be sure we don't overwrite them if not displayed.

campbellssource commented 1 year ago

I'm experiencing this too however, my changes are not being saved. the OP says they are saved without error. I'm using Desktop wallet 0.11 (for Vega.0.70)

pennyandrews commented 1 year ago

The fix in .71 needs to be patched into .70 before we can fix the UI

notbot00 commented 1 year ago

going to close this. tested the network editing, and it seems to work all fine now. also, the tests have been already re-renabled in https://github.com/vegaprotocol/vegawallet-desktop/commit/27af3d68e0edc5b1f380d157c5c0716267a88e80.