vegaprotocol / vegawallet-desktop

Desktop application for Vega Protocol's wallet
MIT License
15 stars 12 forks source link

Cannot submit actions until service status received #589

Closed radoslaw-szpiech closed 1 year ago

radoslaw-szpiech commented 1 year ago

Description

It affects e2e tests mostly. No actions can be submitted until service status is resolved. It's possible that there is a blocking promise starting the service that prevent the router from switching. It affects creating and unlocking wallets, importing networks, etc.

When resolved, waitForNetworkConnected can be removed in most of the tests.

Steps to Reproduce

Option A: Run any e2e test without using waitForNetworkConnected inside. Option B: Try to unlock wallet very quickly, before service status is received.

Expected behavior

Service status should not block user from taking any actions in wallet.

Video

Notice that even that password is provided at the very beginning, user is not taken into the wallet until the service is resolved.

https://user-images.githubusercontent.com/24473278/228260736-1de1e653-d56c-47c9-bf89-fad5a5e3ff84.mov