vegaprotocol / vegawallet-desktop

Desktop application for Vega Protocol's wallet
MIT License
15 stars 12 forks source link

Clean up the github actions to use new matrix output #619

Closed ValentinTrinque closed 1 year ago

ValentinTrinque commented 1 year ago

We are currently relying on an ugly hack to retrieve the compiled frontend in the build-application job because we can't resolve the cache key using the hashFile due to automatic end-of-line conversion done in the tracked files on windows.

We couldn't rely on job outputs to transmit the forged cache key, because it comes from a matrix job, and output from matrix is not supported, yet on production. (As the date of the writing, this feature has been merged but not deployed).

But that should be the way to go. So when it's full available, we should update the github action to remove the ugly hack by the matrix output.

Reference