vegardit / docker-gitea-act-runner

Docker image based on debian:stable-slim to run Gitea's act_runner as a Docker container
https://buymeacoffee.com/vegardit
Apache License 2.0
164 stars 16 forks source link

failure in /opt/run_runner.sh during startup. #19

Closed wblew closed 1 year ago

wblew commented 1 year ago

Commit 5dd910707adb2bd095ad71c3b62116c8ffc8c579 broke startup. It introduced backtick chars into a comment in the image/config.template.yaml file. During that file's expansion by /opt/run_runner.sh those backticks cause script failure.

Here is some tracing with the GITEA_RUNNER_LOG_EFFECTIVE_CONFIG: true

gitea-runner-runner-1  |   # Like: ["macos-arm64:host", "ubuntu-latest:docker://node:16-bullseye", "ubuntu-22.04:docker://node:16-bullseye"]
gitea-runner-runner-1  |   # If it's empty when registering, it will ask for inputting labels.
gitea-runner-runner-1  | /opt/run_runner.sh: line 45: deamon: command not found
gitea-runner-runner-1  | /opt/run_runner.sh: line 45: .runner: command not found
gitea-runner-runner-1  |   # If it's empty when execute , will use labels in  file.

See my PR #18

sebthom commented 1 year ago

Thanks for reporting. With https://github.com/vegardit/docker-gitea-act-runner/commit/6b859904150e3f53a4dd4ebf16bc4c10bd1b291c backticks are no longer expanded/interpolated if present in the YAML file.