vegas-cmf / core

Vegas CMF Core
MIT License
30 stars 7 forks source link

support for phalcon 2.x #52

Closed krzysztof-kabala closed 7 years ago

krzysztof-kabala commented 8 years ago

hi guys, Would be grat to move vegas to XXI century :)

I found some issues which not allow to run vegas (core) on phalcon 2.x env. After simple code refactor I got working vegas on newest phalcon without any errors.

1

solution:

/vendor/vegas-cmf/core/src/Bootstrap/ModulesInitializerTrait.php:57

$config->merge(new Config($moduleConfig));

2

solution:

/vendor/vegas-cmf/core/src/Mvc/Application.php:41

public function registerModules(array $modules, $merge = null)

3

solution:

/vendor/vegas-cmf/core/src/DI/InjectionAwareTrait.php:38

public function setDI(DiInterface $dependencyInjector)

4

solution:

/vendor/vegas-cmf/core/src/Mvc/ModuleAbstract.php:42

public function registerAutoloaders(DiInterface $dependencyInjector = null)

5

solution:

/vendor/vegas-cmf/core/src/Mvc/ModuleAbstract.php:78

public function registerServices(DiInterface $di)

6

solution:

/vendor/vegas-cmf/core/src/Mvc/View.php:99

protected function _engineRender($engines, $viewPath, $silence, $mustClean, BackendInterface $cache = null)

Its core issues only, but rest of modules is going over the hill. Bon Appetit! :)

arius86 commented 8 years ago

We are working currently on 2.x branch (you can see that it is here in repository). Thanks for your effort, sadly all those fixes are already known by us and fixed in 2.x branch.