search

vegas-viz / Vegas

The missing MatPlotLib for Scala + Spark
MIT License
730 stars 98 forks source link

Remove implicit val renderer from generated notebooks #104

Closed rogermenezes closed 7 years ago

rogermenezes commented 7 years ago

After Jeremy's fixes below, the implicit renderer variable is no longer required: https://github.com/vegas-viz/Vegas/pull/86 https://github.com/vegas-viz/Vegas/pull/99

Hence, taking it off in the NotebookGenerator.

codecov-io commented 7 years ago

Codecov Report

Merging #104 into master will increase coverage by 3.32%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage    70.3%   73.63%   +3.32%     
==========================================
  Files          27       27              
  Lines        1785     2560     +775     
  Branches        6        6              
==========================================
+ Hits         1255     1885     +630     
- Misses        530      675     +145
Impacted Files Coverage Δ
core/src/main/scala/vegas/spec/Spec.scala 73.9% <0%> (+4.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7403c28...0efa216. Read the comment docs.

dbtsai commented 7 years ago

LGTM. Merged into master. Thanks.