search

vegas-viz / Vegas

The missing MatPlotLib for Scala + Spark
MIT License
730 stars 98 forks source link

Update to Scala 2.12 #106

Open hmf opened 7 years ago

hmf commented 7 years ago

Any plans to update and publish Vegas for Scala 2.12?

TIA

hmf commented 7 years ago

I took a shot a doing this and failed. One problem is the dependency: "flink-scala" of "org.apache.flink"

This does not seem its going to be solved too soon. See: https://issues.apache.org/jira/browse/FLINK-5005

Any suggestions? The only other idea that comes to mind is to split the dependent projects into separate projects (Flink and Spark?) so that one can at least have Vegas working?

TIA

mrkowalski commented 7 years ago

+1

ckchow commented 6 years ago

The only parts of this project that depend on spark and flink are the spark and flink dependencies, respectively. I think it is possible to build and publish just the core and macros for 2.12. However, I'm not sure how to configure sbt to do that. I tried by adding a different root project for each of the 2.11 and 2.12 versions, but that doesn't seem to work.

ckchow commented 6 years ago

well, I have a fork that compiles and publishes the 2.12 artifacts for base Vegas if anyone is interested. (https://github.com/ckchow/Vegas/tree/cchow/scala_2.12) There's an outstanding PR for it here, but you can sbt publishM2 or whatever if you want to use the snapshot for now.

ckchow commented 6 years ago

could we cut a new release for 2.12 support?

emarx commented 6 years ago

Hi, looks like this thread has been dead for a little while. Are there plans to support 2.12?

sbrunk commented 6 years ago

It looks like cross publishing 2.11 and 2.12 has been merged back in February but published binary artifacts would make it much easier to use it in Ammonite etc. Any plans to cut a release in the near future?

m01 commented 5 years ago

The linked Flink issue is marked as Resolved in Flink 1.7.0

sbrunk commented 5 years ago

@aishfenton since we were talking about this last week in Lausanne and someone even asked about it in my talk, here's another gentle request to publish a 2.12 version.

/cc @jeremyrsmith