search

vegas-viz / Vegas

The missing MatPlotLib for Scala + Spark
MIT License
730 stars 98 forks source link

fix for #124 #125

Open jezzarax opened 6 years ago

jezzarax commented 6 years ago

Updated version of circe to 0.9.0 to make vegas work in ammonite shell.

jezzarax commented 6 years ago

I guess we need to wait for @aishfenton to release argus with updated circe version for the tests to be fixed.

jasonmoore2k commented 6 years ago

Any plans to complete this work and move up to circe 0.9.x?

jasonmoore2k commented 6 years ago

Sorry about that, I only noticed your last comment after I submitted mine. Is Argus a vital part of how Vegas works? If not, would removing that dependency be an option for upgrading circe?

jezzarax commented 6 years ago

Yup, Argus seems quite important for Vegas, I see some activity in Argus repo, will check later if there were any relevant updates to help this PR.

jasonmoore2k commented 6 years ago

The only relevant update is the bumping of the circe version, yeah? This and other things are hitting master over there but not actually being released. Would it be difficult to reach out to @aishfenton to release it as-is to then pull the new version into Vegas?

My motivation is that I'm also trying to use Vegas with other packages that use circe 0.9.x and ideally would like no conflicts to work around.

rgbkrk commented 6 years ago

Hey we've gotten other maintainers on board (@oshikiri being one of them) -- would you like to revisit this + rebase? I'd love to see this work well in Ammonite and jupyter-scala. 😄

dankolesnikov commented 5 years ago

https://github.com/vegas-viz/Vegas/issues/156

Overview of the issue with circe 0.9.x.. @oshikiri @aishfenton how is the work with upgrading Argus to use scalameta going? Can I help?

oshikiri commented 5 years ago

@dankolesnikov I don't know about the progress...