search

vegas-viz / Vegas

The missing MatPlotLib for Scala + Spark
MIT License
730 stars 98 forks source link

Disable body margin of user agent stylesheet #131

Closed oshikiri closed 6 years ago

oshikiri commented 6 years ago

When I tried the example notebook with jupyter-scala (on Chromium browser v64.0.3282.140), I have noticed that the user agent stylesheet increases the height of the content in iframe and then a scroll bar appears.

In order to disable body margin of user agent stylesheet, I added margin: 0px; to <body> tag.

Before

image

After

image

codecov-io commented 6 years ago

Codecov Report

Merging #131 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #131   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          27     27           
  Lines        1783   1783           
  Branches        5      5           
=====================================
  Misses       1783   1783
Impacted Files Coverage Δ
...c/main/scala/vegas/render/StaticHTMLRenderer.scala 0% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa925dd...e313bef. Read the comment docs.

dbtsai commented 6 years ago

LGTM.