Open dankolesnikov opened 6 years ago
@aishfenton @oshikiri
My suggestion is to reduce the number of lines in vegas.spec. Spec by modularizing it. There are more than 2000 lines in a single file.
core/src/main/scala/vegas/spec/Spec.scala
is automatically generated by argus package (c.f. https://github.com/vegas-viz/Vegas/issues/93 and here).
@oshikiri Updates on this:
Assuming there is a breaking change in circe 0.7 - 0.9. Do you know of any?
I don't know about it. Could you send a pull request and check using travis-ci?
Vegas doesn't graph if the user imports circe 0.9.3 in Zeppelin.
To reproduce in Zeppelin, import the following in the spark interpreter and run a sample Vegas example:
Throws exception:
Attaching screenshots: Failure: circe 0.9.3 is imported
Success: no circe library is imported
I am currently working on the fix for this.
vegas.spec. Spec
singleton seems to be the one that requires changes. I'd like to connect with contributors/founder who wrote that code. My suggestion is to reduce the number of lines invegas.spec. Spec
by modularizing it. There are more than 2000 lines in a single file. Any feedback?