DSL Improvements - Githubissues

jeremyrsmith commented 7 years ago

Replace implicit conversions with implicit ops class
Introduce implicit class ShowRender
- Macro guesses appropriate default ShowRender instance
- Eliminates the need for import boilerplate in notebooks

I did this mainly because implicit views can often cause problems due to variance of the type arguments; making an invariant subtrait resolves that problem. Since we're already using macros, we can also go ahead and guess which of several common environments we're in (based on README) and build a default instance to the environment.

codecov-io commented 7 years ago

Current coverage is 70.23% (diff: 40.00%)

Merging #86 into master will increase coverage by 0.05%

@@             master        #86   diff @@
==========================================
  Files            25         27     +2   
  Lines          1774       1784    +10   
  Methods        1771       1778     +7   
  Messages          0          0          
  Branches          3          6     +3   
==========================================
+ Hits           1245       1253     +8   
- Misses          529        531     +2   
  Partials          0          0

Powered by Codecov. Last update 77c56d1...53d8909

aishfenton commented 7 years ago

Thanks Jeremy for PR. Will review in detail soon. But first glance it looks solid.

vegas-viz / Vegas

DSL Improvements #86

Current coverage is 70.23% (diff: 40.00%)