search

vegas-viz / Vegas

The missing MatPlotLib for Scala + Spark
MIT License
730 stars 98 forks source link

Use HTTPS for CDN #87

Closed tjdett closed 7 years ago

tjdett commented 7 years ago

Using HTTP breaks HTML for content served over HTTPS. The CDN supports HTTP/2, so it's faster to fetch from HTTPS anyway.

Another option is omitting the scheme and letting the browser resolve it, however this would break HTML served from file:// with no real benefit.

codecov-io commented 7 years ago

Current coverage is 70.18% (diff: 100%)

Merging #87 into master will not change coverage

@@             master        #87   diff @@
==========================================
  Files            25         25          
  Lines          1774       1774          
  Methods        1771       1768     -3   
  Messages          0          0          
  Branches          3          6     +3   
==========================================
  Hits           1245       1245          
  Misses          529        529          
  Partials          0          0

Powered by Codecov. Last update 77c56d1...fc613aa

DarinJ commented 7 years ago

+1 Ran into the http/https issue with Jupyter when upgrading. Looking through the git history it happened between 3.3 and 3.4. Would be cool to figure out how to unit test this to avoid regressions, but seems kind of tough.

dbtsai commented 7 years ago

Thanks. merged into master.