vegastrike / Assets-Masters

Vega Strike Upon The Coldest Sea Original Game Data Art Sources (e.g. hi-poly/hi-res source models/images)
8 stars 6 forks source link

Version Validation #19

Open BenjamenMeyer opened 3 years ago

BenjamenMeyer commented 3 years ago

How do we make sure the Release Version is the correctly specified?

Continuation of discussion from https://github.com/vegastrike/Assets-Production/pull/38

BenjamenMeyer commented 3 years ago

Some discussed options:

We should at least do the validation step during the release processes while we figure this out; that will satisfy requirements for 0.7.x release if we don't have something by then.

NOTE: This is presently marked against the next release (0.7.x) just to keep it at the top of our priorities. It can slip to 0.8.x or 0.9.x if need be.

stephengtuggy commented 2 years ago

We have come a long ways with regard to versioning in the last few months. With the 0.8.x release series, we should be able to ensure that the desired version -- including git commit SHA -- is automatically included, correctly, in the installer filenames, installer versions, and code for both the Game Engine and the Assets.

As a next step, I'm thinking maybe we do away with hard-coded version numbers altogether, and just have the relevant parts of the game (like the Introduction and Credits screens) pull the version in code, of the engine and of the game assets, and dynamically display those. How does that sound to you guys?

BenjamenMeyer commented 2 years ago

Agreed. We're close to being able to have a single point of version definition. The engine should be really close; most of the work probably needs to be done on the Asset side, but now that the Engine exposes a version to the assets that can be done - we just have to require that the Engine API Version is 1 or greater to do so.