search

vegastrike / Assets-Masters

Vega Strike Upon The Coldest Sea Original Game Data Art Sources (e.g. hi-poly/hi-res source models/images)
8 stars 6 forks source link

CPack/Installer should copy `vegastrike.config` into `$HOME/.vegastrike` #26

Open stephengtuggy opened 3 years ago

stephengtuggy commented 3 years ago

Describe the bug The installer doesn't currently copy the vegastrike.config file into ~/.vegastrike, only into /usr/share/vegastrike. So users have to copy it manually, or use another method to get the file into the proper directory.

To Reproduce

  1. Install the Vega Strike engine, v0.7.0 beta 10, followed by the Assets beta.
  2. Try running vegastrike or vsettings.

Expected behavior There should already be a default vegastrike.config file in the $HOME/.vegastrike directory to start with. Both vsettings and vegastrike binaries should "just work" with that file, albeit with some limitations in terms of graphics resolution, etc.

Please complete the following information):

Additional context Originally reported as https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/417#issuecomment-774571108 Then filed as https://github.com/vegastrike/Vega-Strike-Engine-Source/issues/420 Moving the issue to the correct (I think) repository.

BenjamenMeyer commented 3 years ago

I'm not sure this is something the installer can do; rather the default probably should be at (for example) /usr/share/vegastrike/config, and then copied over to the user's profile (~/.vegastrike) only when saved.

Reason being: the installer doesn't know anything about the user, especially on Linux; and we should try to be consistent across platforms.

stephengtuggy commented 3 years ago

Hmm. I see your point.

I guess this raises another question: Should Vega Strike / vsUTCS be a system-wide installation? A per-user installation? Should they support both configurations?

BenjamenMeyer commented 3 years ago

@stephengtuggy yes it should be system wide by design; though the user's installation system (at least on Windows) may offer a user-only type installation. I don't think Linux Package Managers typically provide for a user-specific install. Not sure about Mac. AFAIK only Windows does, but even then it might fall to the installer to decide if that's an option (likely) in which case we should support it if we could.

stephengtuggy commented 3 years ago

Filed a follow-up issue, vegastrike/Assets-Production#50

BenjamenMeyer commented 3 years ago

We need to get 0.7.x out the door; deferring this as it'll be more research oriented to determine an answer

BenjamenMeyer commented 3 years ago

as we're getting ready to release 0.7.0 and we want a fast turn around on 0.8.x i'm deferring this to 0.9.x

BenjamenMeyer commented 3 years ago

system-wide vs user installation is #27 but that ultimately comes down to what the system is capable of (Linux distros don't often support user-only installs).